chore: enforce lint across codebase and ban "maybe" in identifiers

Remove member-ordering and complexity eslint-disable comments by reordering
class members and applying targeted fixes. Add metoyou/no-maybe-in-naming,
type-safe WebRTC e2e harness helpers, and resolve remaining lint errors so
npm run lint exits cleanly.

Co-authored-by: Cursor <cursoragent@cursor.com>

toju-app/src/app/store/users/user-avatar.effects.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/member-ordering */
 import { Injectable, inject } from '@angular/core';
 import {
   Actions,
@@ -109,13 +108,6 @@ export function shouldApplyAvatarTransfer(
 
 @Injectable()
 export class UserAvatarEffects {
-  private readonly actions$ = inject(Actions);
-  private readonly store = inject(Store);
-  private readonly webrtc = inject(RealtimeSessionFacade);
-  private readonly db = inject(DatabaseService);
-  private readonly avatars = inject(ProfileAvatarFacade);
-
-  private readonly pendingTransfers = new Map<string, PendingAvatarTransfer>();
 
   persistCurrentAvatar$ = createEffect(
     () =>
@@ -267,6 +259,18 @@ export class UserAvatarEffects {
     )
   );
 
+  private readonly actions$ = inject(Actions);
+
+  private readonly store = inject(Store);
+
+  private readonly webrtc = inject(RealtimeSessionFacade);
+
+  private readonly db = inject(DatabaseService);
+
+  private readonly avatars = inject(ProfileAvatarFacade);
+
+  private readonly pendingTransfers = new Map<string, PendingAvatarTransfer>();
+
   private buildAvatarSummary(user: Pick<User, 'oderId' | 'id' | 'avatarHash' | 'avatarUpdatedAt' | 'profileUpdatedAt'>): ChatEvent {
     return {
       type: 'user-avatar-summary',
@@ -535,4 +539,5 @@ export class UserAvatarEffects {
       reader.readAsDataURL(blob);
     });
   }
+
 }

toju-app/src/app/store/users/users.effects.ts

@@ -1,7 +1,6 @@
 /**
  * Users store effects (load, kick, ban, host election, profile persistence).
  */
-/* eslint-disable @typescript-eslint/member-ordering */
 import { Injectable, inject } from '@angular/core';
 import { Router } from '@angular/router';
 import {
@@ -68,16 +67,6 @@ type IncomingModerationAction =
 
 @Injectable()
 export class UsersEffects {
-  private actions$ = inject(Actions);
-  private store = inject(Store);
-  private db = inject(DatabaseService);
-  private serverDirectory = inject(ServerDirectoryFacade);
-  private webrtc = inject(RealtimeSessionFacade);
-  private readonly i18n = inject(AppI18nService);
-  private readonly authTokenStore = inject(AuthTokenStoreService);
-  private readonly signalServerAuthRetries = new Map<string, { count: number; windowStart: number }>();
-  private readonly signalServerAuth = inject(SignalServerAuthService);
-  private readonly router = inject(Router);
 
   /** Prepares persisted state for a successful login before exposing the user in-memory. */
   authenticateUser$ = createEffect(() =>
@@ -255,54 +244,6 @@ export class UsersEffects {
     )
   );
 
-  private clearStartupVoiceConnection(user: User): User {
-    const voiceState = user.voiceState;
-
-    if (!voiceState)
-      return user;
-
-    const hasStaleConnectionState =
-      voiceState.isConnected ||
-      voiceState.isSpeaking ||
-      voiceState.roomId !== undefined ||
-      voiceState.serverId !== undefined;
-
-    if (!hasStaleConnectionState)
-      return user;
-
-    return {
-      ...user,
-      voiceState: {
-        ...voiceState,
-        isConnected: false,
-        isSpeaking: false,
-        roomId: undefined,
-        serverId: undefined
-      }
-    };
-  }
-
-  private async prepareAuthenticatedUserStorage(
-    user: User,
-    loginResponse?: {
-      id: string;
-      username: string;
-      displayName: string;
-      token: string;
-      expiresAt: number;
-    }
-  ): Promise<void> {
-    setStoredCurrentUserId(user.id);
-    await this.db.initialize();
-    await this.db.setCurrentUserId(user.id);
-    await this.db.saveUser(user);
-
-    if (user.homeSignalServerUrl && loginResponse) {
-      this.signalServerAuth.upsertCredentialFromLogin(user.homeSignalServerUrl, loginResponse, { provisioned: false });
-      await this.signalServerAuth.ensureHomeProvisionSecret(user);
-    }
-  }
-
   /** Loads all users associated with a specific room from the local database. */
   loadRoomUsers$ = createEffect(() =>
     this.actions$.pipe(
@@ -664,6 +605,74 @@ export class UsersEffects {
     { dispatch: false }
   );
 
+  private actions$ = inject(Actions);
+
+  private store = inject(Store);
+
+  private db = inject(DatabaseService);
+
+  private serverDirectory = inject(ServerDirectoryFacade);
+
+  private webrtc = inject(RealtimeSessionFacade);
+
+  private readonly i18n = inject(AppI18nService);
+
+  private readonly authTokenStore = inject(AuthTokenStoreService);
+
+  private readonly signalServerAuthRetries = new Map<string, { count: number; windowStart: number }>();
+
+  private readonly signalServerAuth = inject(SignalServerAuthService);
+
+  private readonly router = inject(Router);
+
+  private clearStartupVoiceConnection(user: User): User {
+    const voiceState = user.voiceState;
+
+    if (!voiceState)
+      return user;
+
+    const hasStaleConnectionState =
+      voiceState.isConnected ||
+      voiceState.isSpeaking ||
+      voiceState.roomId !== undefined ||
+      voiceState.serverId !== undefined;
+
+    if (!hasStaleConnectionState)
+      return user;
+
+    return {
+      ...user,
+      voiceState: {
+        ...voiceState,
+        isConnected: false,
+        isSpeaking: false,
+        roomId: undefined,
+        serverId: undefined
+      }
+    };
+  }
+
+  private async prepareAuthenticatedUserStorage(
+    user: User,
+    loginResponse?: {
+      id: string;
+      username: string;
+      displayName: string;
+      token: string;
+      expiresAt: number;
+    }
+  ): Promise<void> {
+    setStoredCurrentUserId(user.id);
+    await this.db.initialize();
+    await this.db.setCurrentUserId(user.id);
+    await this.db.saveUser(user);
+
+    if (user.homeSignalServerUrl && loginResponse) {
+      this.signalServerAuth.upsertCredentialFromLogin(user.homeSignalServerUrl, loginResponse, { provisioned: false });
+      await this.signalServerAuth.ensureHomeProvisionSecret(user);
+    }
+  }
+
   private resolveRoom(roomId: string | undefined, currentRoom: Room | null, savedRooms: Room[]): Room | null {
     if (!roomId)
       return currentRoom;
@@ -896,4 +905,5 @@ export class UsersEffects {
       catchError(() => EMPTY)
     );
   }
+
 }