chore: enforce lint across codebase and ban "maybe" in identifiers

Remove member-ordering and complexity eslint-disable comments by reordering
class members and applying targeted fixes. Add metoyou/no-maybe-in-naming,
type-safe WebRTC e2e harness helpers, and resolve remaining lint errors so
npm run lint exits cleanly.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
2026-06-11 11:08:26 +02:00
parent b630bacdc6
commit 79c6f91cd6
138 changed files with 4286 additions and 2310 deletions

View File

@@ -8,39 +8,75 @@ import type { LocalScreenShareState } from '../media/screen-share.manager';
export class WebRtcStateController {
readonly peerId: Signal<string>;
readonly isConnected: Signal<boolean>;
readonly hasEverConnected: Signal<boolean>;
readonly isVoiceConnected: Signal<boolean>;
readonly connectedPeers: Signal<string[]>;
readonly isMuted: Signal<boolean>;
readonly isDeafened: Signal<boolean>;
readonly isCameraEnabled: Signal<boolean>;
readonly isScreenSharing: Signal<boolean>;
readonly isNoiseReductionEnabled: Signal<boolean>;
readonly screenStream: Signal<MediaStream | null>;
readonly isScreenShareRemotePlaybackSuppressed: Signal<boolean>;
readonly forceDefaultRemotePlaybackOutput: Signal<boolean>;
readonly hasConnectionError: Signal<boolean>;
readonly connectionErrorMessage: Signal<string | null>;
readonly shouldShowConnectionError: Signal<boolean>;
readonly peerLatencies: Signal<ReadonlyMap<string, number>>;
get currentServerId(): string | null {
return this.activeServerId;
}
private activeServerId: string | null = null;
private readonly _localPeerId = signal<string>(uuidv4());
private readonly _isSignalingConnected = signal(false);
private readonly _isVoiceConnected = signal(false);
private readonly _connectedPeers = signal<string[]>([]);
private readonly _isMuted = signal(false);
private readonly _isDeafened = signal(false);
private readonly _isCameraEnabled = signal(false);
private readonly _isScreenSharing = signal(false);
private readonly _isNoiseReductionEnabled = signal(false);
private readonly _screenStreamSignal = signal<MediaStream | null>(null);
private readonly _isScreenShareRemotePlaybackSuppressed = signal(false);
private readonly _forceDefaultRemotePlaybackOutput = signal(false);
private readonly _hasConnectionError = signal(false);
private readonly _connectionErrorMessage = signal<string | null>(null);
private readonly _hasEverConnected = signal(false);
private readonly _peerLatencies = signal<ReadonlyMap<string, number>>(new Map());
constructor() {
@@ -72,10 +108,6 @@ export class WebRtcStateController {
this.peerLatencies = computed(() => this._peerLatencies());
}
get currentServerId(): string | null {
return this.activeServerId;
}
getLocalPeerId(): string {
return this._localPeerId();
}
@@ -173,4 +205,5 @@ export class WebRtcStateController {
this._hasConnectionError.set(!anyConnected);
this._connectionErrorMessage.set(anyConnected ? null : (errorMessage ?? 'network.signaling.disconnected'));
}
}