chore: enforce lint across codebase and ban "maybe" in identifiers

Remove member-ordering and complexity eslint-disable comments by reordering class members and applying targeted fixes. Add metoyou/no-maybe-in-naming, type-safe WebRTC e2e harness helpers, and resolve remaining lint errors so npm run lint exits cleanly. Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-11 11:08:26 +02:00
parent b630bacdc6
commit 79c6f91cd6
138 changed files with 4286 additions and 2310 deletions
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/member-ordering */
 import { ChatEvent } from '../../../shared-kernel';
 import { DATA_CHANNEL_LABEL } from '../realtime.constants';
 import { recordDebugNetworkDownloadRates } from '../logging/debug-network-metrics';
@@ -63,10 +62,6 @@ interface PeerInboundByteSnapshot {
 * offer/answer negotiation, ICE candidates, and P2P reconnection.
 */
 export class PeerConnectionManager {
-  private readonly state = createPeerConnectionManagerState();
-  private readonly lastInboundByteSnapshots = new Map<string, PeerInboundByteSnapshot>();
-  private statsPollTimer: ReturnType<typeof setInterval> | null = null;
-  private transportStatsPollInFlight = false;

  /** Active peer connections keyed by remote peer ID. */
  readonly activePeerConnections = this.state.activePeerConnections;
@@ -90,13 +85,76 @@ export class PeerConnectionManager {
  readonly peerLatencyChanged$ = this.state.peerLatencyChanged$;

  readonly peerConnected$ = this.state.peerConnected$;
+
  readonly peerDisconnected$ = this.state.peerDisconnected$;
+
  readonly remoteStream$ = this.state.remoteStream$;
+
  readonly messageReceived$ = this.state.messageReceived$;

  /** Emitted whenever the connected peer list changes. */
  readonly connectedPeersChanged$ = this.state.connectedPeersChanged$;

+  private readonly state = createPeerConnectionManagerState();
+
+  private readonly lastInboundByteSnapshots = new Map<string, PeerInboundByteSnapshot>();
+
+  private statsPollTimer: ReturnType<typeof setInterval> | null = null;
+
+  private transportStatsPollInFlight = false;
+
+  private get context(): PeerConnectionManagerContext {
+    return {
+      logger: this.logger,
+      callbacks: this.callbacks,
+      state: this.state
+    };
+  }
+
+  private get connectionHandlers(): ConnectionLifecycleHandlers {
+    return {
+      clearPeerDisconnectGraceTimer: (peerId: string) => this.clearPeerDisconnectGraceTimer(peerId),
+      addToConnectedPeers: (peerId: string) => this.addToConnectedPeers(peerId),
+      clearPeerReconnectTimer: (peerId: string) => this.clearPeerReconnectTimer(peerId),
+      requestVoiceStateFromPeer: (peerId: string) => this.requestVoiceStateFromPeer(peerId),
+      schedulePeerDisconnectRecovery: (peerId: string) =>
+        this.schedulePeerDisconnectRecovery(peerId),
+      trackDisconnectedPeer: (peerId: string) => this.trackDisconnectedPeer(peerId),
+      removePeer: (peerId: string, options?: RemovePeerOptions) => this.removePeer(peerId, options),
+      schedulePeerReconnect: (peerId: string) => this.schedulePeerReconnect(peerId),
+      handleRemoteTrack: (event: RTCTrackEvent, peerId: string) =>
+        this.handleRemoteTrack(event, peerId),
+      setupDataChannel: (channel: RTCDataChannel, peerId: string) =>
+        this.setupDataChannel(channel, peerId)
+    };
+  }
+
+  private get negotiationHandlers(): NegotiationHandlers {
+    return {
+      createPeerConnection: (remotePeerId: string, isInitiator: boolean) =>
+        this.createPeerConnection(remotePeerId, isInitiator)
+    };
+  }
+
+  private get recoveryHandlers(): RecoveryHandlers {
+    return {
+      removePeer: (peerId: string, options?: RemovePeerOptions) => this.removePeer(peerId, options),
+      replaceDataChannel: (peerId: string, expectedChannel: RTCDataChannel) =>
+        this.replaceDataChannel(peerId, expectedChannel),
+      createPeerConnection: (peerId: string, isInitiator: boolean) =>
+        this.createPeerConnection(peerId, isInitiator),
+      createAndSendOffer: (peerId: string) => this.createAndSendOffer(peerId)
+    };
+  }
+
+  private get dataChannelHandlers(): DataChannelLifecycleHandlers {
+    return {
+      clearDataChannelRecoveryTimer: (peerId: string) => this.clearDataChannelRecoveryTimer(peerId),
+      scheduleDataChannelRecovery: (peerId: string, channel: RTCDataChannel, reason: string) =>
+        this.scheduleDataChannelRecovery(peerId, channel, reason)
+    };
+  }
+
  constructor(
    private readonly logger: WebRTCLogger,
    private callbacks: PeerConnectionCallbacks
@@ -253,62 +311,10 @@ export class PeerConnectionManager {
    this.peerLatencyChanged$.complete();
  }

-  private get context(): PeerConnectionManagerContext {
-    return {
-      logger: this.logger,
-      callbacks: this.callbacks,
-      state: this.state
-    };
-  }
-
-  private get connectionHandlers(): ConnectionLifecycleHandlers {
-    return {
-      clearPeerDisconnectGraceTimer: (peerId: string) => this.clearPeerDisconnectGraceTimer(peerId),
-      addToConnectedPeers: (peerId: string) => this.addToConnectedPeers(peerId),
-      clearPeerReconnectTimer: (peerId: string) => this.clearPeerReconnectTimer(peerId),
-      requestVoiceStateFromPeer: (peerId: string) => this.requestVoiceStateFromPeer(peerId),
-      schedulePeerDisconnectRecovery: (peerId: string) =>
-        this.schedulePeerDisconnectRecovery(peerId),
-      trackDisconnectedPeer: (peerId: string) => this.trackDisconnectedPeer(peerId),
-      removePeer: (peerId: string, options?: RemovePeerOptions) => this.removePeer(peerId, options),
-      schedulePeerReconnect: (peerId: string) => this.schedulePeerReconnect(peerId),
-      handleRemoteTrack: (event: RTCTrackEvent, peerId: string) =>
-        this.handleRemoteTrack(event, peerId),
-      setupDataChannel: (channel: RTCDataChannel, peerId: string) =>
-        this.setupDataChannel(channel, peerId)
-    };
-  }
-
-  private get negotiationHandlers(): NegotiationHandlers {
-    return {
-      createPeerConnection: (remotePeerId: string, isInitiator: boolean) =>
-        this.createPeerConnection(remotePeerId, isInitiator)
-    };
-  }
-
-  private get recoveryHandlers(): RecoveryHandlers {
-    return {
-      removePeer: (peerId: string, options?: RemovePeerOptions) => this.removePeer(peerId, options),
-      replaceDataChannel: (peerId: string, expectedChannel: RTCDataChannel) =>
-        this.replaceDataChannel(peerId, expectedChannel),
-      createPeerConnection: (peerId: string, isInitiator: boolean) =>
-        this.createPeerConnection(peerId, isInitiator),
-      createAndSendOffer: (peerId: string) => this.createAndSendOffer(peerId)
-    };
-  }
-
  private setupDataChannel(channel: RTCDataChannel, remotePeerId: string): void {
    setupDataChannel(this.context, channel, remotePeerId, this.dataChannelHandlers);
  }

-  private get dataChannelHandlers(): DataChannelLifecycleHandlers {
-    return {
-      clearDataChannelRecoveryTimer: (peerId: string) => this.clearDataChannelRecoveryTimer(peerId),
-      scheduleDataChannelRecovery: (peerId: string, channel: RTCDataChannel, reason: string) =>
-        this.scheduleDataChannelRecovery(peerId, channel, reason)
-    };
-  }
-
  private handleRemoteTrack(event: RTCTrackEvent, remotePeerId: string): void {
    handleRemoteTrack(this.context, event, remotePeerId);
  }
@@ -507,4 +513,5 @@ export class PeerConnectionManager {
  private roundMetric(value: number): number {
    return Math.round(value * 1000) / 1000;
  }
+
 }