chore: enforce lint across codebase and ban "maybe" in identifiers

Remove member-ordering and complexity eslint-disable comments by reordering
class members and applying targeted fixes. Add metoyou/no-maybe-in-naming,
type-safe WebRTC e2e harness helpers, and resolve remaining lint errors so
npm run lint exits cleanly.

Co-authored-by: Cursor <cursoragent@cursor.com>

toju-app/src/app/infrastructure/persistence/app-resume.storage.ts

@@ -59,7 +59,7 @@ function scheduleStorageRemove(key: string): void {
   scheduleStorageFlush();
 }
 
-function readMaybePending(key: string): string | null {
+function readPendingOrStored(key: string): string | null {
   if (pendingWrites.has(key)) {
     return pendingWrites.get(key) ?? null;
   }
@@ -73,8 +73,8 @@ function readMaybePending(key: string): string | null {
 
 export function loadGeneralSettingsFromStorage(): GeneralSettings {
   try {
-    const raw = readMaybePending(getUserScopedStorageKey(STORAGE_KEY_GENERAL_SETTINGS))
-      ?? readMaybePending(STORAGE_KEY_GENERAL_SETTINGS);
+    const raw = readPendingOrStored(getUserScopedStorageKey(STORAGE_KEY_GENERAL_SETTINGS))
+      ?? readPendingOrStored(STORAGE_KEY_GENERAL_SETTINGS);
 
     if (!raw) {
       return { ...DEFAULT_GENERAL_SETTINGS };
@@ -99,8 +99,8 @@ export function saveGeneralSettingsToStorage(patch: Partial<GeneralSettings>): G
 
 export function loadLastViewedChatFromStorage(userId?: string | null): LastViewedChatSnapshot | null {
   try {
-    const raw = readMaybePending(getUserScopedStorageKey(STORAGE_KEY_LAST_VIEWED_CHAT, userId))
-      ?? readMaybePending(STORAGE_KEY_LAST_VIEWED_CHAT);
+    const raw = readPendingOrStored(getUserScopedStorageKey(STORAGE_KEY_LAST_VIEWED_CHAT, userId))
+      ?? readPendingOrStored(STORAGE_KEY_LAST_VIEWED_CHAT);
 
     if (!raw) {
       return null;

toju-app/src/app/infrastructure/persistence/database.service.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/member-ordering, */
 import {
   inject,
   Injectable,
@@ -38,16 +37,22 @@ export interface RoomMessageStats {
  */
 @Injectable({ providedIn: 'root' })
 export class DatabaseService {
-  private readonly platform = inject(PlatformService);
-  private readonly browserDb = inject(BrowserDatabaseService);
-  private readonly capacitorDb = inject(CapacitorDatabaseService);
-  private readonly electronDb = inject(ElectronDatabaseService);
-  private initializationPromise: Promise<void> | null = null;
-  private validatedUserScope: string | null | undefined;
 
   /** Reactive flag: `true` once {@link initialize} has completed. */
   isReady = signal(false);
 
+  private readonly platform = inject(PlatformService);
+
+  private readonly browserDb = inject(BrowserDatabaseService);
+
+  private readonly capacitorDb = inject(CapacitorDatabaseService);
+
+  private readonly electronDb = inject(ElectronDatabaseService);
+
+  private initializationPromise: Promise<void> | null = null;
+
+  private validatedUserScope: string | null | undefined;
+
   /** The active storage backend for the current platform. */
   private get backend() {
     const backendKind = resolveDatabaseBackend({
@@ -94,22 +99,6 @@ export class DatabaseService {
     await this.initializationPromise;
   }
 
-  private async ensureReady(): Promise<void> {
-    const userScope = getStoredCurrentUserId();
-
-    if (this.isReady() && this.validatedUserScope === userScope) {
-      return;
-    }
-
-    await this.initialize();
-  }
-
-  private async withReady<T>(operation: () => Promise<T>): Promise<T> {
-    await this.ensureReady();
-
-    return operation();
-  }
-
   /** Persist a single chat message. */
   saveMessage(message: Message) { return this.withReady(() => this.backend.saveMessage(message)); }
 
@@ -232,4 +221,21 @@ export class DatabaseService {
 
   /** Wipe all persisted data. */
   clearAllData() { return this.withReady(() => this.backend.clearAllData()); }
+
+  private async ensureReady(): Promise<void> {
+    const userScope = getStoredCurrentUserId();
+
+    if (this.isReady() && this.validatedUserScope === userScope) {
+      return;
+    }
+
+    await this.initialize();
+  }
+
+  private async withReady<T>(operation: () => Promise<T>): Promise<T> {
+    await this.ensureReady();
+
+    return operation();
+  }
+
 }