chore: enforce lint across codebase and ban "maybe" in identifiers

Remove member-ordering and complexity eslint-disable comments by reordering
class members and applying targeted fixes. Add metoyou/no-maybe-in-naming,
type-safe WebRTC e2e harness helpers, and resolve remaining lint errors so
npm run lint exits cleanly.

Co-authored-by: Cursor <cursoragent@cursor.com>

toju-app/src/app/features/room/voice-workspace/voice-workspace.component.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/member-ordering, complexity */
 import { CommonModule } from '@angular/common';
 import {
   Component,
@@ -88,55 +87,42 @@ import { APP_TRANSLATE_IMPORTS, AppI18nService } from '../../../core/i18n';
   }
 })
 export class VoiceWorkspaceComponent {
-  private readonly destroyRef = inject(DestroyRef);
-  private readonly elementRef = inject<ElementRef<HTMLElement>>(ElementRef);
-  private readonly store = inject(Store);
-  private readonly webrtc = inject(VoiceConnectionFacade);
-  private readonly screenShare = inject(ScreenShareFacade);
-  private readonly viewport = inject(ViewportService);
   readonly isMobile = this.viewport.isMobile;
-  private readonly voicePlayback = inject(VoicePlaybackService);
-  private readonly workspacePlayback = inject(VoiceWorkspacePlaybackService);
-  private readonly voiceSession = inject(VoiceSessionFacade);
-  private readonly voiceWorkspace = inject(VoiceWorkspaceService);
-  private readonly appI18n = inject(AppI18nService);
-
-  private readonly remoteStreamRevision = signal(0);
-
-  private readonly miniWindowWidth = 320;
-  private readonly miniWindowHeight = 228;
-  private miniWindowDragging = false;
-  private miniDragOffsetX = 0;
-  private miniDragOffsetY = 0;
-  private wasExpanded = false;
-  private wasAutoHideChrome = false;
-  private headerHideTimeoutId: ReturnType<typeof setTimeout> | null = null;
-  private readonly observedRemoteStreams = new Map<string, {
-    stream: MediaStream;
-    cleanup: () => void;
-  }>();
 
   readonly miniPreviewRef = viewChild<ElementRef<HTMLVideoElement>>('miniPreview');
 
   readonly currentRoom = this.store.selectSignal(selectCurrentRoom);
+
   readonly currentUser = this.store.selectSignal(selectCurrentUser);
+
   readonly onlineUsers = this.store.selectSignal(selectOnlineUsers);
+
   readonly voiceSessionInfo = this.voiceSession.voiceSession;
 
   readonly showExpanded = this.voiceWorkspace.isExpanded;
+
   readonly showMiniWindow = this.voiceWorkspace.isMinimized;
+
   readonly shouldConnectRemoteShares = this.voiceWorkspace.shouldConnectRemoteShares;
+
   readonly miniPosition = this.voiceWorkspace.miniWindowPosition;
+
   readonly showWorkspaceHeader = signal(true);
 
   readonly isConnected = computed(() => this.webrtc.isVoiceConnected());
+
   readonly isMuted = computed(() => this.webrtc.isMuted());
+
   readonly isDeafened = computed(() => this.webrtc.isDeafened());
+
   readonly isScreenSharing = computed(() => this.screenShare.isScreenSharing());
 
   readonly includeSystemAudio = signal(false);
+
   readonly screenShareQuality = signal<ScreenShareQuality>('balanced');
+
   readonly askScreenShareQuality = signal(true);
+
   readonly showScreenShareQualityDialog = signal(false);
 
   readonly connectedVoiceUsers = computed(() => {
@@ -290,18 +276,23 @@ export class VoiceWorkspaceComponent {
   });
 
   readonly isWidescreenMode = computed(() => this.widescreenShareId() !== null);
+
   readonly shouldAutoHideChrome = computed(
     () => this.showExpanded() && this.isWidescreenMode() && this.activeShares().length > 0
   );
+
   readonly hasMultipleShares = computed(() => this.activeShares().length > 1);
+
   readonly widescreenShare = computed(
     () => this.activeShares().find((share) => share.id === this.widescreenShareId()) ?? null
   );
+
   readonly focusedAudioShare = computed(() => {
     const share = this.widescreenShare();
 
     return share && !share.isLocal && share.hasAudio ? share : null;
   });
+
   readonly focusedShareTitle = computed(() => {
     const share = this.widescreenShare();
 
@@ -317,6 +308,7 @@ export class VoiceWorkspaceComponent {
       ? this.appI18n.instant('voice.workspace.yourCamera')
       : this.appI18n.instant('voice.workspace.yourScreen');
   });
+
   readonly thumbnailShares = computed(() => {
     const widescreenShareId = this.widescreenShareId();
 
@@ -326,9 +318,11 @@ export class VoiceWorkspaceComponent {
 
     return this.activeShares().filter((share) => share.id !== widescreenShareId);
   });
+
   readonly miniPreviewShare = computed(
     () => this.widescreenShare() ?? this.activeShares()[0] ?? null
   );
+
   readonly miniPreviewTitle = computed(() => {
     const previewShare = this.miniPreviewShare();
 
@@ -344,7 +338,9 @@ export class VoiceWorkspaceComponent {
       ? this.appI18n.instant('voice.workspace.yourCamera')
       : this.appI18n.instant('voice.workspace.yourScreen');
   });
+
   readonly liveShareCount = computed(() => this.activeShares().length);
+
   readonly connectedVoiceChannelName = computed(() => {
     const me = this.currentUser();
     const room = this.currentRoom();
@@ -361,21 +357,55 @@ export class VoiceWorkspaceComponent {
 
     return sessionRoomName || this.appI18n.instant('voice.workspace.voiceLounge');
   });
+
   readonly serverName = computed(
     () => this.currentRoom()?.name || this.voiceSessionInfo()?.serverName || this.appI18n.instant('voice.workspace.voiceServer')
   );
 
-  liveStreamCountLabel(count: number): string {
-    const key = count === 1 ? 'voice.workspace.liveStream' : 'voice.workspace.liveStreams';
+  private readonly destroyRef = inject(DestroyRef);
 
-    return this.appI18n.instant(key, { count });
-  }
+  private readonly elementRef = inject<ElementRef<HTMLElement>>(ElementRef);
 
-  miniWindowStreamHint(count: number): string {
-    const key = count === 1 ? 'voice.workspace.miniWindowHintSingle' : 'voice.workspace.miniWindowHint';
+  private readonly store = inject(Store);
 
-    return this.appI18n.instant(key, { count });
-  }
+  private readonly webrtc = inject(VoiceConnectionFacade);
+
+  private readonly screenShare = inject(ScreenShareFacade);
+
+  private readonly viewport = inject(ViewportService);
+
+  private readonly voicePlayback = inject(VoicePlaybackService);
+
+  private readonly workspacePlayback = inject(VoiceWorkspacePlaybackService);
+
+  private readonly voiceSession = inject(VoiceSessionFacade);
+
+  private readonly voiceWorkspace = inject(VoiceWorkspaceService);
+
+  private readonly appI18n = inject(AppI18nService);
+
+  private readonly remoteStreamRevision = signal(0);
+
+  private readonly miniWindowWidth = 320;
+
+  private readonly miniWindowHeight = 228;
+
+  private miniWindowDragging = false;
+
+  private miniDragOffsetX = 0;
+
+  private miniDragOffsetY = 0;
+
+  private wasExpanded = false;
+
+  private wasAutoHideChrome = false;
+
+  private headerHideTimeoutId: ReturnType<typeof setTimeout> | null = null;
+
+  private readonly observedRemoteStreams = new Map<string, {
+    stream: MediaStream;
+    cleanup: () => void;
+  }>();
 
   constructor() {
     this.destroyRef.onDestroy(() => {
@@ -509,14 +539,6 @@ export class VoiceWorkspaceComponent {
     });
   }
 
-  onWorkspacePointerMove(): void {
-    if (!this.shouldAutoHideChrome()) {
-      return;
-    }
-
-    this.revealWorkspaceChrome();
-  }
-
   @HostListener('window:mousemove', ['$event'])
   onWindowMouseMove(event: MouseEvent): void {
     if (!this.miniWindowDragging) {
@@ -548,6 +570,26 @@ export class VoiceWorkspaceComponent {
     this.ensureMiniWindowPosition();
   }
 
+  liveStreamCountLabel(count: number): string {
+    const key = count === 1 ? 'voice.workspace.liveStream' : 'voice.workspace.liveStreams';
+
+    return this.appI18n.instant(key, { count });
+  }
+
+  miniWindowStreamHint(count: number): string {
+    const key = count === 1 ? 'voice.workspace.miniWindowHintSingle' : 'voice.workspace.miniWindowHint';
+
+    return this.appI18n.instant(key, { count });
+  }
+
+  onWorkspacePointerMove(): void {
+    if (!this.shouldAutoHideChrome()) {
+      return;
+    }
+
+    this.revealWorkspaceChrome();
+  }
+
   trackUser(index: number, user: User): string {
     return this.getUserPeerKey(user) || `${index}`;
   }
@@ -1057,4 +1099,5 @@ export class VoiceWorkspaceComponent {
   private clamp(value: number, min: number, max: number): number {
     return Math.min(Math.max(value, min), max);
   }
+
 }