chore: enforce lint across codebase and ban "maybe" in identifiers

Remove member-ordering and complexity eslint-disable comments by reordering
class members and applying targeted fixes. Add metoyou/no-maybe-in-naming,
type-safe WebRTC e2e harness helpers, and resolve remaining lint errors so
npm run lint exits cleanly.

Co-authored-by: Cursor <cursoragent@cursor.com>

toju-app/src/app/domains/direct-message/feature/dm-chat/dm-chat.component.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/member-ordering */
 import {
   Component,
   computed,
@@ -84,55 +83,68 @@ interface DmStatusLabel {
 export class DmChatComponent {
   @ViewChild(ChatMessageComposerComponent) composer?: ChatMessageComposerComponent;
 
-  private readonly route = inject(ActivatedRoute);
-  private readonly store = inject(Store);
-  private readonly electronBridge = inject(ElectronBridgeService);
-  private readonly attachments = inject(AttachmentFacade);
-  private readonly klipy = inject(KlipyService);
-  private readonly linkMetadata = inject(LinkMetadataService);
-  private readonly profileCard = inject(ProfileCardService);
-  private readonly viewport = inject(ViewportService);
-  private readonly metadataRequestKeys = new Set<string>();
-  private openedConversationId: string | null = null;
-  private readonly i18n = inject(AppI18nService);
   readonly isMobile = this.viewport.isMobile;
+
   readonly directCalls = inject(DirectCallService);
+
   readonly directMessages = inject(DirectMessageService);
+
   readonly currentUser = this.store.selectSignal(selectCurrentUser);
+
   readonly allUsers = this.store.selectSignal(selectAllUsers);
+
   readonly showGifPicker = signal(false);
+
   readonly conversationId = input<string | null>(null);
+
   readonly showCallButton = input(true);
+
   readonly composerBottomPadding = signal(140);
+
   readonly gifPickerAnchorRight = signal(16);
+
   readonly linkMetadataByMessageId = signal<Record<string, LinkMetadata[]>>({});
+
   readonly replyTo = signal<Message | null>(null);
+
   readonly lightboxState = signal<ChatLightboxState | null>(null);
+
   readonly galleryAttachments = signal<Attachment[] | null>(null);
+
   readonly imageContextMenu = signal<ChatMessageImageContextMenuEvent | null>(null);
+
   readonly routeConversationId = toSignal(this.route.paramMap.pipe(map((params) => params.get('conversationId'))), {
     initialValue: this.route.snapshot.paramMap.get('conversationId')
   });
+
   readonly effectiveConversationId = computed(() => this.conversationId() ?? this.routeConversationId());
+
   readonly currentUserId = computed(() => this.currentUser()?.oderId || this.currentUser()?.id || '');
+
   readonly conversation = this.directMessages.selectedConversation;
+
   readonly klipyEnabled = computed(() => this.klipy.isEnabled(null));
+
   readonly conversationKey = computed(() => this.conversation()?.id ?? 'dm:none');
+
   readonly typingUsers = computed(() => {
     void this.directMessages.typingEntries();
 
     return this.directMessages.typingUsers(this.conversation()?.id);
   });
+
   readonly peerUser = computed(() => {
     const conversation = this.conversation();
 
     return conversation ? this.peerUserFor(conversation) : null;
   });
+
   readonly isGroupConversation = computed(() => {
     const conversation = this.conversation();
 
     return !!conversation && (conversation.kind === 'group' || conversation.participants.length > 2);
   });
+
   readonly participantUsers = computed<User[]>(() => {
     const conversation = this.conversation();
     const knownUsers = this.allUsers();
@@ -164,6 +176,7 @@ export class DmChatComponent {
       );
     });
   });
+
   readonly messageStatuses = computed<DmStatusLabel[]>(() => {
     const conversation = this.conversation();
     const currentUserId = this.currentUserId();
@@ -179,6 +192,7 @@ export class DmChatComponent {
         status: message.status
       }));
   });
+
   readonly chatMessages = computed<Message[]>(() => {
     const conversation = this.conversation();
     const metadataByMessageId = this.linkMetadataByMessageId();
@@ -196,7 +210,11 @@ export class DmChatComponent {
         roomId: conversation.id,
         channelId: 'direct-message',
         senderId: message.senderId,
-        senderName: knownUser?.displayName || participant?.displayName || (message.senderId === this.currentUserId() ? this.i18n.instant('common.labels.you') : message.senderId),
+        senderName: knownUser?.displayName
+          || participant?.displayName
+          || (message.senderId === this.currentUserId()
+            ? this.i18n.instant('common.labels.you')
+            : message.senderId),
         content: message.content,
         timestamp: message.timestamp,
         kind: message.kind,
@@ -209,6 +227,7 @@ export class DmChatComponent {
       };
     });
   });
+
   readonly peerName = computed(() => {
     const conversation = this.conversation();
     const currentUserId = this.currentUserId();
@@ -221,6 +240,7 @@ export class DmChatComponent {
 
     return peerId ? conversation?.participantProfiles[peerId]?.displayName || peerId : this.i18n.instant('dm.chat.defaultTitle');
   });
+
   readonly peerCallIcon = computed(() => {
     const conversation = this.conversation();
 
@@ -232,6 +252,7 @@ export class DmChatComponent {
 
     return peer && this.directCalls.isCallingUser(peer) ? 'lucidePhoneCall' : 'lucidePhone';
   });
+
   readonly canCallConversation = computed(() => {
     const conversation = this.conversation();
 
@@ -246,6 +267,28 @@ export class DmChatComponent {
     return !!this.peerUser();
   });
 
+  private readonly route = inject(ActivatedRoute);
+
+  private readonly store = inject(Store);
+
+  private readonly electronBridge = inject(ElectronBridgeService);
+
+  private readonly attachments = inject(AttachmentFacade);
+
+  private readonly klipy = inject(KlipyService);
+
+  private readonly linkMetadata = inject(LinkMetadataService);
+
+  private readonly profileCard = inject(ProfileCardService);
+
+  private readonly viewport = inject(ViewportService);
+
+  private readonly metadataRequestKeys = new Set<string>();
+
+  private openedConversationId: string | null = null;
+
+  private readonly i18n = inject(AppI18nService);
+
   constructor() {
     effect(() => {
       const conversationId = this.effectiveConversationId();
@@ -659,4 +702,5 @@ export class DmChatComponent {
 
     return `${names.slice(0, 3).join(', ')} +${names.length - 3}`;
   }
+
 }