fix: attachments broken

toju-app/src/app/domains/attachment/application/services/attachment-persistence.service.ts

@@ -5,8 +5,8 @@ import { selectCurrentRoomName } from '../../../../store/rooms/rooms.selectors';
 import { DatabaseService } from '../../../../infrastructure/persistence';
 import { AttachmentStorageService } from '../../infrastructure/services/attachment-storage.service';
 import type { Attachment, AttachmentMeta } from '../../domain/models/attachment.model';
-import { MAX_AUTO_SAVE_SIZE_BYTES } from '../../domain/constants/attachment.constants';
 import { LEGACY_ATTACHMENTS_STORAGE_KEY } from '../../domain/constants/attachment-transfer.constants';
+import { isBlobObjectUrl, needsBlobObjectUrlForInlineDisplay } from '../../domain/logic/attachment-display-url.rules';
 import { mergeAttachmentLocalPaths } from '../../domain/logic/attachment-persistence.rules';
 import { AttachmentRuntimeStore } from './attachment-runtime.store';
 
@@ -113,7 +113,17 @@ export class AttachmentPersistenceService {
   }
 
   async tryRestoreAttachmentFromLocal(attachment: Attachment): Promise<boolean> {
-    if (attachment.available) {
+    const restored = await this.ensureInlineDisplayObjectUrl(attachment);
+
+    if (restored) {
+      attachment.requestError = undefined;
+    }
+
+    return restored;
+  }
+
+  async ensureInlineDisplayObjectUrl(attachment: Attachment): Promise<boolean> {
+    if (!needsBlobObjectUrlForInlineDisplay(attachment.objectUrl)) {
       return true;
     }
 
@@ -134,19 +144,14 @@ export class AttachmentPersistenceService {
       return false;
     }
 
-    if (await this.restoreMediaAttachmentFromFileUrl(attachment, diskPath)) {
-      attachment.requestError = undefined;
-      return true;
-    }
-
     const base64 = await this.attachmentStorage.readFile(diskPath);
 
     if (!base64) {
       return false;
     }
 
+    this.revokeAttachmentObjectUrl(attachment);
     this.restoreAttachmentFromDisk(attachment, base64);
-    attachment.requestError = undefined;
     return true;
   }
 
@@ -291,24 +296,14 @@ export class AttachmentPersistenceService {
     );
   }
 
-  private async restoreMediaAttachmentFromFileUrl(attachment: Attachment, filePath: string): Promise<boolean> {
-    if (!this.isPlayableMedia(attachment)) {
-      return false;
+  private revokeAttachmentObjectUrl(attachment: Attachment): void {
+    if (!attachment.objectUrl || !isBlobObjectUrl(attachment.objectUrl)) {
+      return;
     }
 
-    const fileUrl = await this.attachmentStorage.getFileUrl(filePath);
-
-    if (!fileUrl) {
-      return false;
-    }
-
-    attachment.objectUrl = fileUrl;
-    attachment.available = true;
-    return true;
-  }
-
-  private isPlayableMedia(attachment: Pick<Attachment, 'mime'>): boolean {
-    return attachment.mime.startsWith('video/') || attachment.mime.startsWith('audio/');
+    try {
+      URL.revokeObjectURL(attachment.objectUrl);
+    } catch { /* ignore */ }
   }
 
   private async getRetainedSavedPathsForOtherMessages(messageId: string): Promise<Set<string>> {